Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply color maps to all types of depth tensors #1686

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Apply color maps to all types of depth tensors #1686

merged 5 commits into from
Mar 23, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 23, 2023 •
edited
Loading

Also split the crazy triple-dispatch super-match statement into three different functions

image

Checklist

@emilk emilk added the 📺 re_viewer affects re_viewer itself label Mar 23, 2023
jleibs
jleibs approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Much cleaner.

@emilk emilk merged commit e87ee88 into main Mar 23, 2023
@emilk emilk deleted the emilk/tensor-fixes branch March 23, 2023 14:16
This was referenced Mar 23, 2023
Closed
Merged
@emilk emilk mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @jleibs