Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the web icon #1688

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Update the web icon #1688

merged 2 commits into from
Mar 23, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 23, 2023 •
edited
Loading

Use the same icon as our main site.

image

Checklist

@jleibs jleibs added the 🕸️ web regarding running the viewer in a browser label Mar 23, 2023
@jleibs jleibs marked this pull request as ready for review March 23, 2023 14:21
@Wumpf Wumpf self-requested a review March 23, 2023 15:37
Wumpf
Wumpf approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

def. the right move to use the same icon as main page!
But orthogonally I don't think its a good favicon. It doesn't scale all that well at that size...

@Wumpf Wumpf merged commit c42e1f1 into main Mar 23, 2023
@Wumpf Wumpf deleted the jleibs/web_icon branch March 23, 2023 15:39
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jleibs @Wumpf