Fix web crash on missing uniform buffer padding #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alignment is actually already there, but wgpu/Naga doesn't see it at this point.
Wumpf
force-pushed
the
andreas/fix-web-issue-with-missing-uniform-padding
branch
from
0f48b09
to
c8d0b55
Compare
|
Not so sure about that :D. Drives me a bit nuts. Want to point the finger at some code location for not doing validation correctly but .. ehrm.. it's complicated? |
|
Confirmed working: https://app.rerun.io/commit/c8d0b55/?url=/data/prerelease/colmap_fiat.rrd |
emilk
added
🕸️ web
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment is actually already there, but wgpu/Naga doesn't see it at this point.
Fixes #1697
Checklist