Track changed state in nav mode combo box #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
reviewed
Mar 24, 2023
| @@ -315,24 +315,29 @@ impl ViewSpatialState { | |||
| .on_hover_text("The virtual camera which controls what is shown on screen."); | |||
| ui.vertical(|ui| { | |||
| let mut nav_mode = *self.nav_mode.get(); | |||
| let nav_mode_response = egui::ComboBox::from_id_source("nav_mode") | |||
| let changed = egui::ComboBox::from_id_source("nav_mode") | |||
There was a problem hiding this comment.
A comment with a link to an egui issue would be nice if we go that route
There was a problem hiding this comment.
The ComboBox just opens a ui - it can't/shouldn't know if anything in that ui changes
emilk
approved these changes
Mar 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't seem like the
.changed()response of the combo box does what we expected. Maybe I'm missing something?I confirmed this works.
Resolves: #1702
Checklist