Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CI publish latest tagged web-viewer to app.rerun.io #1725

Merged
merged 3 commits into from
Mar 30, 2023
Merged

Make CI publish latest tagged web-viewer to app.rerun.io #1725

merged 3 commits into from
Mar 30, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 28, 2023

I think the only way to test this is to merge it and then make a new releae

Checklist

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) ⛴ release Related to shipping or publishing labels Mar 28, 2023
emilk
emilk commented Mar 28, 2023
View reviewed changes
.github/workflows/rust.yml Outdated Show resolved Hide resolved
jleibs
jleibs reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not positive this will always do what we expect. I think it will end up sensitive to how the latest tag gets updated or created, but worth a shot.

.github/workflows/rust.yml Outdated Show resolved Hide resolved
.github/workflows/python.yml Outdated Show resolved Hide resolved
@emilk
Copy link
Member Author

emilk commented Mar 29, 2023

Thanks for the clarifications @jleibs - I'll point these to upload latest to a latest folder, but hold off on re-directing app.rerun.io to it until next release

teh-cmc
teh-cmc approved these changes Mar 29, 2023
View reviewed changes
.github/workflows/python.yml Outdated Show resolved Hide resolved
@emilk @teh-cmc
fix copy-paste
0a305e2 
Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
@emilk emilk changed the title Make sure the CI publishes latest tag to app.rerun.io Make CI publish latest tagged web-viewer to app.rerun.io Mar 30, 2023
@emilk emilk merged commit b2298e9 into main Mar 30, 2023
@emilk emilk deleted the emilk/publish-latest-web-viewer-from-ci branch March 30, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs left review comments

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) ⛴ release Related to shipping or publishing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilk @teh-cmc @jleibs