Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved renderer label handling #1731

Merged
merged 5 commits into from
Mar 29, 2023
Merged

improved renderer label handling #1731

merged 5 commits into from
Mar 29, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 29, 2023

  • remove push_str methods again and go all in on format!
  • use field based label names in more (most) places
  • new macro for using source file as debug label for shader modules

can be well reviewed commit by commit

Checklist

@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 🧑‍💻 dev experience developer experience (excluding CI) labels Mar 29, 2023
emilk
emilk approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/re_renderer/src/wgpu_resources/shader_module_pool.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 6d219e6 into main Mar 29, 2023
@Wumpf Wumpf deleted the andreas/re_renderer/improved-label-handling branch March 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wumpf @emilk