Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering artifact for non-color images #1886

Merged
merged 1 commit into from Apr 18, 2023
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 17, 2023

Problem: we apply filtering before we apply the color map. This means large changes in depth images produce unexpected colors when interpolating. A similar problem occurs for label maps.

Solution: use nearest filtering for depth images and label maps.

An alternative solution is to apply the color maps before filtering, but that is far more expensive, and likely not worth it.

Before:

image

After:

image

Checklist

@emilk emilk added the 🔺 re_renderer affects re_renderer itself label Apr 17, 2023
@nikolausWest
Copy link
Member

nearest filtering for depth images and label maps

Seems like the best approach for these either way

@emilk emilk merged commit 1ddb2d3 into main Apr 18, 2023
30 of 36 checks passed
@emilk emilk deleted the emilk/fix-filtering-artifact branch April 18, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants