Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double clicking camera no longer focusing on said camera #1911

Merged
merged 1 commit into from Apr 19, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Apr 18, 2023

Also cleans up how a camera/pinhole transform is referenced in scene/ui code: Only by its path now since several pinholes on the same path don't make sense (in fact we warn when you try to log this)

Fixes #1883

Checklist

Also cleans up how a camera/pinhole transform is referenced in scene/ui code: Only by its path now since several pinholes on the same path don't make sense (in fact we warn when you try to log this)
@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Apr 18, 2023
@teh-cmc teh-cmc changed the title Fix double clicking camera no longer focusing on said camera. Fix double clicking camera no longer focusing on said camera Apr 19, 2023
@teh-cmc teh-cmc merged commit 6127e02 into main Apr 19, 2023
46 of 56 checks passed
@teh-cmc teh-cmc deleted the andreas/fix-camera-focus-on-double-click branch April 19, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

double clicking camera (frustum wireframe) no longer focuses on said camera
2 participants