Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: don't starve web-socket decoding task #1977

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fix: don't starve web-socket decoding task #1977

merged 1 commit into from
Apr 26, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 26, 2023 •
edited
Loading

Give the task that decodes incoming log messages a bit of time before calling requestAnimationFrame.

Closes #963

Should improve web performance on Chrome and Edge

TODO:

Checklist

PR Build Summary: https://build.rerun.io/pr/1977

@emilk
Fix: don't starve web-socket decoding task
3fc7122 
Give the task that decodes incoming log messages a bit of time
before calling `requestAnimationFrame`.

Closes #963

Should improve web performance on Chrome and Edge
@emilk emilk added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 📉 performance Optimization, memory use, etc labels Apr 26, 2023
jleibs
jleibs approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a significant improvement in Chrome performance loading e.g. colmap.

Note: the main improvement here is via the websocket conection not hosted rrd.

@emilk
Copy link
Member Author

emilk commented Apr 26, 2023

Note: the main improvement here is via the websocket conection not hosted rrd.

Oh yeah, of course 🤦

Thanks for testing 🙏

@emilk emilk merged commit b8bbe7c into main Apr 26, 2023
18 checks passed
@emilk emilk deleted the emilk/fix-chrome-ingestion branch April 26, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 📉 performance Optimization, memory use, etc 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading of data is extremely slow in web on Chrome
2 participants
@emilk @jleibs