Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK batching/revamp 3: sunset PythonSession #1985

Merged
merged 42 commits into from
May 4, 2023
Merged

SDK batching/revamp 3: sunset PythonSession #1985

merged 42 commits into from
May 4, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Apr 27, 2023 •
edited
Loading

TODO:

  • update rerun-docs if necessary
    • init mandatory
    • batching env vars
  • just py-run-all
  • just py-run-all without init calls shouldnt do anything crazy
  • missing init in notebook should clearly tell you what went wrong
  1. SDK batching/revamp 1: impl DataTableBatcher #1980
  2. Replace Session with RecordingContext #1983
  3. SDK batching/revamp 2.1: clock example for Rust #2000
  4. SDK batching/revamp 2.2: homegrown arrow size estimation routines #2002
  5. SDK batching/revamp 3: sunset PythonSession #1985

On top of #1983
Fixes #1619

Future work:

@teh-cmc teh-cmc added 🐍 Python API Python logging API do-not-merge Do not merge this PR labels Apr 27, 2023
@teh-cmc teh-cmc force-pushed the cmc/sdk_revamp/3_py_revamp branch 3 times, most recently from f15a4eb to f0e6ccb Compare April 27, 2023 10:01
This was referenced Apr 27, 2023
Merged
Merged
@teh-cmc teh-cmc force-pushed the cmc/sdk_revamp/2_rust_revamp branch from ac1fac2 to 14130c5 Compare April 27, 2023 16:30
Base automatically changed from cmc/sdk_revamp/2_rust_revamp to main May 4, 2023 09:16
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label May 4, 2023
teh-cmc
teh-cmc commented May 4, 2023
View reviewed changes
crates/re_sdk_comms/src/buffered_client.rs Outdated Show resolved Hide resolved
examples/python/clock/main.py Outdated Show resolved Hide resolved
examples/python/minimal/main.py Show resolved Hide resolved
rerun_py/src/python_bridge.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc marked this pull request as ready for review May 4, 2023 18:45
jleibs
jleibs approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems straight forward. Nice improvement.

rerun_py/src/python_bridge.rs Outdated Show resolved Hide resolved
@teh-cmc teh-cmc merged commit 256edfb into main May 4, 2023
15 checks passed
@teh-cmc teh-cmc deleted the cmc/sdk_revamp/3_py_revamp branch May 4, 2023 21:24
@teh-cmc teh-cmc mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue: end-to-end batching
2 participants
@teh-cmc @jleibs