When hovering a 3D view in the presence of images, fix previously incorrect depth shown in 2D view #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
changed the title
emilk
approved these changes
May 2, 2023
|
Hmm no, it is the 3D view that is hovered and the 2D view that gets the depth shown. Doesn't get accross on the screenshots since they don't show the mouse cursor, but it is in fact mousing the 3D view |
Wumpf
changed the title
Wumpf
changed the title
Wumpf
changed the title
Wumpf
deleted the
andreas/fix-broken-3d-to-2d-depth-measure-in-presence-of-image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small but annoying issue I noticed while working on #2008, somewhat related to #1818
Before:
After:
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2009