[pure refactor] "namespace" flag parameters for linestrip & point cloud shader flags #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🔺 re_renderer
Wumpf
changed the title
teh-cmc
approved these changes
May 4, 2023
crates/re_viewer/src/ui/view_spatial/scene/scene_part/cameras.rs
Outdated
Show resolved
Hide resolved
|
uhoh. Thanks! I'll look through them again, don't want surprises! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, remove
NO_COLOR_GRADIENTin favor ofFLAG_COLOR_GRADIENT(stuff that came up on #2008)
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2033