Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mp_pose example 2D points having incorrectly interpreted depth #2034

Merged
merged 2 commits into from May 4, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 3, 2023

made up depth values are problematic now since there's no camera set since #2008 . Internally we generate an automatic camera causing the skeleton points in the 2D view to be off if they have a real depth

Checklist

PR Build Summary: https://build.rerun.io/pr/2034

@Wumpf Wumpf added examples Issues relating to the Rerun examples 🦟 regression A thing that used to work in an earlier release labels May 3, 2023
@Wumpf Wumpf changed the title fix mp_pose demo Fix mp_pose example 2D points having incorrectly interpreted depth May 3, 2023
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Wumpf Wumpf merged commit 8b17bf5 into main May 4, 2023
15 checks passed
@Wumpf Wumpf deleted the andreas/fix-mp_pose branch May 4, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants