Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pure refactor] move selection state into an independent crate, re_viewer_context #2037

Merged
merged 6 commits into from
May 4, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 3, 2023

Another step towards splitting up the viewer. This creates a "base" crate to which the viewer context will move.
So far the only thing moved is the selection state and the associated "universal Item enum" that is used to refer to "things" in the viewer.

Part of

Checklist

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality labels May 3, 2023
@Wumpf Wumpf changed the title move selection state into an independent crate, re_viewer_context [pure refactor] move selection state into an independent crate, re_viewer_context May 3, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated
@@ -90,6 +93,7 @@ tinyvec = { version = "1.6", features = ["alloc", "rustc_1_55"] }
tokio = { version = "1.24", default-features = false }
wgpu = { version = "0.16" }
wgpu-core = { version = "0.16" }
slotmap = { version = "1.0.6", features = ["serde"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort!

crates/re_viewer_context/Cargo.toml Outdated Show resolved Hide resolved
@Wumpf
Copy link
Member Author

Wumpf commented May 4, 2023

orst!

@Wumpf Wumpf merged commit eb8cf3a into main May 4, 2023
@Wumpf Wumpf deleted the andreas/move-selection-state-to-re_viewer_context branch May 4, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📺 re_viewer affects re_viewer itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants