Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix twice as wide alpha-to-coverage edge on circles, leading to artifacts #2053

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix twice as wide alpha-to-coverage edge on circles, leading to artifacts #2053

merged 2 commits into from
May 5, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 5, 2023 •
edited by github-actions bot
Loading

Before:
image

After:
image

Regression since MSAA for circles was handled like for spheres in 0.5

Checklist

PR Build Summary: https://build.rerun.io/pr/2053

@Wumpf Wumpf added the 🔺 re_renderer affects re_renderer itself label May 5, 2023
@emilk emilk added the 🪳 bug Something isn't working label May 5, 2023
emilk
emilk approved these changes May 5, 2023
View reviewed changes
crates/re_renderer/shader/point_cloud.wgsl Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 11aec5e into main May 5, 2023
15 checks passed
@Wumpf Wumpf deleted the andreas/re_renderer/circle-msaa-fix branch May 5, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wumpf @emilk