Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect, warn and gracefully handle corrupt cells in lookup_arrow #2055

Merged
merged 3 commits into from
May 9, 2023
Merged

Detect, warn and gracefully handle corrupt cells in lookup_arrow #2055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbe9288
Fix crash when clicking on an entity with varying number of components.
Wumpf May 5, 2023
aef62cf
remove silly cast
Wumpf May 5, 2023
4c26a9f
don't let corrupt cell go silently
teh-cmc May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/re_query/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ polars = ["dep:polars-core", "re_arrow_store/polars"]
re_arrow_store.workspace = true
re_data_store.workspace = true
re_format.workspace = true
re_log.workspace = true
re_log_types = { workspace = true, features = ["arrow_datagen"] }

# External dependencies:
Expand Down
10 changes: 8 additions & 2 deletions crates/re_query/src/entity_view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,16 @@ impl ComponentWithInstances {
0
} else {
// Otherwise binary search to find the offset of the instance
keys.binary_search(&instance_key.0).ok()? as u32
keys.binary_search(&instance_key.0).ok()?
};

Some(self.values.as_arrow_ref().slice(offset as _, 1))
let arrow_ref = self.values.as_arrow_ref();
(arrow_ref.len() > offset)
.then(|| arrow_ref.slice(offset, 1))
.or_else(|| {
re_log::error_once!("found corrupt cell -- mismatched number of instances");
None
})
}

/// Produce a `ComponentWithInstances` from native component types
Expand Down
Loading