Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect, warn and gracefully handle corrupt cells in lookup_arrow #2055

Merged
merged 3 commits into from
May 9, 2023

Commits on May 5, 2023

  1. Fix crash when clicking on an entity with varying number of components.

    `lookup_arrow` called arrow's `slice` which is defined to panic on out of bounds slices.
    
    example code that would create such an entity
    
    ```rust
        // And some points in front of the rectangle.
        MsgSender::new("2d_layering/points_between_top_and_middle")
            .with_timepoint(sim_time(1 as _))
            .with_component(
                &(0..256).map(|i| Point2D::new(...).collect::<Vec<_>>(),
            )?
            .with_component(&[DrawOrder(1.51)])?
            .send(rec_stream)?;
    ```
    Wumpf committed May 5, 2023
    Configuration menu
    Copy the full SHA
    bbe9288 View commit details
    Browse the repository at this point in the history
  2. remove silly cast

    Wumpf committed May 5, 2023
    Configuration menu
    Copy the full SHA
    aef62cf View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Configuration menu
    Copy the full SHA
    4c26a9f View commit details
    Browse the repository at this point in the history