Introduce (2D) Draw order component #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
enhancement
…ame layer will be made transparent
Wumpf
force-pushed
the
andreas/2d-draw-order
branch
from
c9000e0
to
4e99df5
Compare
|
Can confirm that cherry-picking #2059 on top fixes the splat-related crash. |
teh-cmc
approved these changes
May 9, 2023
jprochazk
pushed a commit
that referenced
this pull request
May 11, 2023
* create depth offset from draw order and patch it through * transparent layers now know about depth offset - only images on the same layer will be made transparent * add some points to layering demo * comments and renames on draw order constants * doc & sample details * images with a shared root & an explicit draw order all go to the same space view now * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only Rust api implemented so far. To solve
we'll also need a python api ofc.
As discussed, the draw order internally maps to a the renderer's depth offset.
Adjusted the heuristic for images to put everything with explicit depth offset into the same space view (otherwise we only do so when two images have the same size).
Furthermore, layered images are now only transparent if they have the dame draw order (default or otherwise).
Added a simple example to demonstrate layering to api_demo plenty of room for improvement there both for esthetics & functionality ;) (TODO)
Checklist
PR Build Summary: https://build.rerun.io/pr/2056