Fix a race condition for notebooks #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
May 9, 2023
| @@ -48,6 +48,11 @@ def as_html( | |||
| # Use a random presentation ID to avoid collisions when multiple recordings are shown in the same notebook. | |||
| presentation_id = "".join(random.choice(string.ascii_letters) for i in range(6)) | |||
|
|
|||
| # TODO(jleibs): flush the specific recording instead of all recordings | |||
jprochazk
pushed a commit
that referenced
this pull request
May 11, 2023
* Flush before generating the html * Link to PR for recording handle
emilk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a race-condition where the generated html is missing some (or all) of the logged messages.
Checklist
PR Build Summary: https://build.rerun.io/pr/2073