Fix failing dependency install of mesh_to_sdf #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
May 10, 2023
emilk
reviewed
May 10, 2023
| @@ -1,4 +1,4 @@ | |||
| mesh_to_sdf===0.0.14 | |||
| -e git+https://github.com/marian42/mesh_to_sdf.git#egg=mesh_to_sdf | |||
There was a problem hiding this comment.
wth is this magic? "egg"? https://youtu.be/hl7-ZmJEB1E?t=24
Is it possible to add a comment here explaining wtf is going on and why we don't just depend on mesh_to_sdf like a normal dependency?
There was a problem hiding this comment.
I watched the video you linked and it didn't help me understand anything about eggs.
I'm just following Pip's orders. But apparently that's what bundled python code is called https://stackoverflow.com/questions/2051192/what-is-a-python-egg
Turns out.. pythons.. lay eggs..
I also found out how to add comments to requirements.txt so I'll link to the ticket etc.
jprochazk
pushed a commit
that referenced
this pull request
May 11, 2023
* Fix failing dependency install of mesh_to_sdf Works around marian42/mesh_to_sdf#38 * add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around marian42/mesh_to_sdf#38
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2081