Stop playback when we reach the end of the data #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would get stuck in "Play" mode, which is both weird and wasteful
emilk
commented
May 11, 2023
Comment on lines
-145
to
-147
| // Don't pause or rewind, just stop moving time forward | ||
| // until we receive more data! | ||
| // This is important for "live view". |
There was a problem hiding this comment.
We now have a "Follow" mode that makes the old behavior and comment obsolete
jleibs
approved these changes
May 11, 2023
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2077
Closes #2083
What
Previously we would get stuck in "Play" mode, which is both weird and wasteful
Checklist
PR Build Summary: https://build.rerun.io/pr/2085