Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize GLTF/GLB texture loading in debug builds #2096

Merged
merged 1 commit into from
May 12, 2023
Merged

Optimize GLTF/GLB texture loading in debug builds #2096

merged 1 commit into from
May 12, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented May 12, 2023 •
edited by github-actions bot
Loading

5x faster in debug builds!

Checklist

PR Build Summary: https://build.rerun.io/pr/2096

@emilk emilk added 🔺 re_renderer affects re_renderer itself 📉 performance Optimization, memory use, etc labels May 12, 2023
@Wumpf Wumpf self-requested a review May 12, 2023 07:33
Wumpf
Wumpf approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

classic rust...
one of these days we'll do this in a compute shader...

@Wumpf Wumpf merged commit f7e83de into main May 12, 2023
17 checks passed
@Wumpf Wumpf deleted the emilk/optimize-glb-tex-loading branch May 12, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📉 performance Optimization, memory use, etc 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf