Switch compression algorithm from zstd to lz4 #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🧑💻 dev experience
Compilation timesTL;DR: nothing won 😭 Before (
|
|
It's strange that re_log_types took so much longer on the lz4 run. It also seems like the whole thing is hitting some bottleneck where it can't parallize - it would be that this is still a win on a machine with less cores than yours, i.e. a strong improvement for many users. Might be worth doing a comparison run that is limited to 4 cores 🤔 |
Advantages: * Faster compilation times * 3x faster encode and decode * Pure Rust crate * Can compress in wasm
|
We've decided to prioritize CPU use right now over disk space. We may revisit this in the future, allowing users to pick different compression algorithms and levels. |
emilk
added a commit
that referenced
this pull request
May 25, 2023
Advantages: * Faster compilation times * 3x faster encode and decode * Pure Rust crate * Can compress in wasm Disadvantages: | example .rrd | zstd | lz4 | | ------------- | ------------- | ------------- | | api_demo | 48 kB | 93 kB | | car | 120 kB | 375 kB | | clock | 28 kB | 53 kB | | colmap | 227 MB | 241 MB | | deep_sdf | 19 MB | 20 MB | | dicom | 39 MB | 64 MB | | nyud | 535 MB | 634 MB | | plots | 89 kB | 163 kB | | raw_mesh | 1.5 MB | 5.6 MB | | text_logging | 1.9 kB | 3.0 kB | I'm not sure what is the best trade-off here. I'm gonna check the compilation times too. Note that these compilation times impact our Rust users, as well as our contributors. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages:
Disadvantages:
I'm not sure what is the best trade-off here. I'm gonna check the compilation times too.
Note that these compilation times impact our Rust users, as well as our contributors.
Checklist
PR Build Summary: https://build.rerun.io/pr/2112