Allow dragging time cursor in plots #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
approved these changes
May 15, 2023
Wumpf
requested changes
May 16, 2023
|
Does the help text need updating? "Right click to move the time cursor to the current position" is still true, and useful if the time cursor is out-of-view or otherwise missing. Documenting that the time cursor is draggable seems unnecessary to me (we usually don't document things that respond when hovered) |
|
well it's not click anymore, it's drag I'd argue. But yeah not a big thing |
|
you can right-click or right-drag to move the time cursor; this PR has not changed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1074
What
Checklist
PR Build Summary: https://build.rerun.io/pr/2115