Web viewer: catch and show panic messages that happens at startup #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🪳 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2151
What
While investigating #2032 I noticed that panics during startup (creating the renderer) went unreported to the user. They were logged, but the web page got stuck in a "Loading…" forever. With this PR we notice such panics and shows the panic message to the user.
This required a substantial refactor of eframe to fix:
This PR also improves
re_web_viewer_serverto make it easier to test locally. For instance:cargo r -p re_web_viewer_server -- --bind 192.168.0.42 --port 1234 --openThis allows me to open up
http://192.168.0.42:1234on my iPhone to test my latest changes.Checklist
PR Build Summary: https://build.rerun.io/pr/2157