Allow users to select the bind address (ip) to use with --bind
#2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is still `0.0.0.0` I'm no network expert, so some of these names could probably be improved
emilk
added
enhancement
jleibs
requested changes
May 17, 2023
jleibs
reviewed
May 17, 2023
jleibs
approved these changes
May 19, 2023
emilk
added a commit
that referenced
this pull request
May 22, 2023
* Allow users to select the bind address (ip) to use with `--bind` The default is still `0.0.0.0` I'm no network expert, so some of these names could probably be improved * Use the local_addr reported back to us * Fix doc-tests * docstring fix * Replace the unspecified "0.0.0.0" ip with "localhost" * Fix doctest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Allow users to select the bind address (ip) to use with
--bindThe default is still
0.0.0.0, and still works (at least on my Mac).I'm no network expert, so some of these names could probably be improved
Checklist
PR Build Summary: https://build.rerun.io/pr/2159