Mitigate depth offset precision issues on web #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
|
... just noticed that zooming in in the api_demo depth offset demo still causes flickering 🤦 |
|
given that the hover preview also flickers this might have a different reason though! |
|
it is for a different reason. doing this in a separate pr! |
emilk
approved these changes
May 23, 2023
emilk
pushed a commit
that referenced
this pull request
May 25, 2023
* run-wasm no longer pops up browser when running with --build-only * add depth offset example * mitigate depth issues on web * deterministic order of depth offset determination * inverte negative if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new re_renderer example to make it easier to look at depth offset and general depth precision issue. Example description in the comments.
Mitigates depth offset issues by blowing up the depth offset by a large value and moving the near plane closer. Tested this with:
Independently, did a fix for
cargo run-wasm --build-onlyto have it not spawn a browser window.Checklist
PR Build Summary: https://build.rerun.io/pr/2187