Premultiply the alpha on the GPU #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Premultiplying on the GPU saves us A LOT of cpu. But texture filtering must happen AFTER premultiplying, which means we need to do texture filtering in software on the shader.
emilk
added
🔺 re_renderer
Wumpf
approved these changes
May 24, 2023
| @@ -51,6 +50,9 @@ struct UniformBuffer { | |||
|
|
|||
| minification_filter: u32, | |||
| magnification_filter: u32, | |||
|
|
|||
| /// Boolean: decode 0-1 sRGB gamma to linear space before filtering? | |||
| decode_srgb: u32, | |||
There was a problem hiding this comment.
wgsl has a (32bit large) bool type, why not use that?
There was a problem hiding this comment.
tried to find spec on when a bool is regarded as true, now not sure if it can be in a uniform buffer. Did you try?
There was a problem hiding this comment.
NOPE
[2023-05-24T15:47:35Z ERROR re_renderer::error_tracker] WGPU error tick_nr=1 description=Validation Error
Caused by:
In Device::create_shader_module
Shader validation error:
┌─ :86:1
│
86 │ var<uniform> rect_info: UniformBuffer;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::GlobalVariable [1]
Global variable [1] 'rect_info' is invalid
Alignment requirements for address space Uniform are not met by [16]
The type is not host-shareable
emilk
added a commit
that referenced
this pull request
May 25, 2023
* Premultiply the alpha on the GPU Premultiplying on the GPU saves us A LOT of cpu. But texture filtering must happen AFTER premultiplying, which means we need to do texture filtering in software on the shader. * Add a TODO * Cleanup * Docfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Premultiplying on the GPU saves us A LOT of CPU time when loading e.g. a png. But texture filtering must happen AFTER premultiplying, which means we need to do texture filtering in software on the shader.
Checklist
PR Build Summary: https://build.rerun.io/pr/2190