Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Retry linkinator #2299

Merged
merged 2 commits into from Jun 1, 2023
Merged

CI: Retry linkinator #2299

merged 2 commits into from Jun 1, 2023

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented Jun 1, 2023

What

Checklist

PR Build Summary: https://build.rerun.io/pr/2299

Docs preview: https://rerun.io/preview/5aa6ab9/docs

@jprochazk jprochazk added the 🧑‍💻 dev experience developer experience (excluding CI) label Jun 1, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that was easy!

@emilk
Copy link
Member

emilk commented Jun 1, 2023

…well, except it doesn't work :P

@jprochazk
Copy link
Member Author

Sorry, should've turned this into a draft. I'm in the process of forking linkinator-action and adding retry option directly into it

@jprochazk jprochazk marked this pull request as draft June 1, 2023 10:38
@jprochazk jprochazk marked this pull request as ready for review June 1, 2023 10:45
@jprochazk jprochazk requested a review from emilk June 1, 2023 10:45
@jprochazk
Copy link
Member Author

Okay, now it hopefully will retry a few times before failing. Of course that requires an actual failure and despite retrying the workflow a few times, it hasn't failed yet, so we'll just have to wait and see. I did also submit the changes as a PR to upstream JustinBeckwith/linkinator-action#157

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it I guess :)

@jprochazk jprochazk merged commit 3d778a2 into main Jun 1, 2023
20 checks passed
@jprochazk jprochazk deleted the jan/retry-linkinator branch June 1, 2023 14:45
emilk pushed a commit that referenced this pull request Jun 15, 2023
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

### Checklist
* [ ] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2299

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/5aa6ab9/docs
<!-- pr-link-docs:end -->
This was referenced Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants