Fix some browsers failing due to 8k texture requirement, pick always highest available now #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
emilk
approved these changes
Jun 13, 2023
emilk
pushed a commit
that referenced
this pull request
Jun 15, 2023
…highest available now (#2409) <!-- Open the PR up as a draft until you feel it is ready for a proper review. Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. Make sure you mention any issues that this PR closes in the description, as well as any other related issues. To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. --> ### What And rename "hardware tier" to "device tier". Since this breaks the "caps are a simple enum"-model, there is `DeviceCaps` on top now. This allows my Mac to ingest 16k textures and my Android mobile phone 4k textures (Chrome allowed only 4k,Firefox allowed 8k 🤦 ) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2409 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/284b7ec/docs Examples preview: https://rerun.io/preview/284b7ec/examples <!-- pr-link-docs:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
And rename "hardware tier" to "device tier". Since this breaks the "caps are a simple enum"-model, there is
DeviceCapson top now.This allows my Mac to ingest 16k textures and my Android mobile phone 4k textures (Chrome allowed only 4k,Firefox allowed 8k 🤦 )
Checklist
PR Build Summary: https://build.rerun.io/pr/2409
Docs preview: https://rerun.io/preview/284b7ec/docs
Examples preview: https://rerun.io/preview/284b7ec/examples