Fix always redrawing in the presence of a 3D space view #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
Wumpf
force-pushed
the
andreas/fix-redraw
branch
from
5bb1bc6
to
44c73c1
Compare
Wumpf
force-pushed
the
andreas/fix-redraw
branch
from
44c73c1
to
c957adc
Compare
Wumpf
added
do-not-merge
|
Fixed for real now! |
teh-cmc
approved these changes
Aug 3, 2023
emilk
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Fixes #2897 ### What Fix regression introduced in #2839 This landed in 0.8. Candidate for potential 0.8.1 release if we decide to do one. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2900) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2900) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/examples)
emilk
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Fixes #2897 ### What Fix regression introduced in #2839 This landed in 0.8. Candidate for potential 0.8.1 release if we decide to do one. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2900) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2900) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/examples)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix regression introduced in #2839
This landed in 0.8. Candidate for potential 0.8.1 release if we decide to do one.
Checklist