Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helix to demo.rerun.io #2930

Merged
merged 4 commits into from Aug 7, 2023
Merged

Add Helix to demo.rerun.io #2930

merged 4 commits into from Aug 7, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 7, 2023

What the title says.

Didn't rename the dna folder on purpose: not particularly looking to deal with broken links all over the place today :)

What

Checklist

@teh-cmc teh-cmc added the examples Issues relating to the Rerun examples label Aug 7, 2023
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice that this "just works"

but now it’s technically out of sync with the walkthrough md which refers to this python file. Well, I think people will survive that

@teh-cmc teh-cmc merged commit 5248422 into main Aug 7, 2023
18 checks passed
@teh-cmc teh-cmc deleted the cmc/helix_demo branch August 7, 2023 17:45
@emilk emilk added this to the 0.8.1 milestone Aug 17, 2023
emilk pushed a commit that referenced this pull request Aug 17, 2023
What the title says.

Didn't rename the `dna` folder on purpose: not particularly looking to
deal with broken links all over the place today :)

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2930) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2930)
- [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fhelix_demo/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fhelix_demo/examples)
@emilk emilk mentioned this pull request Aug 17, 2023
3 tasks
emilk pushed a commit that referenced this pull request Aug 17, 2023
What the title says.

Didn't rename the `dna` folder on purpose: not particularly looking to
deal with broken links all over the place today :)

### What

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2930) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2930)
- [Docs preview](https://rerun.io/preview/pr%3Acmc%2Fhelix_demo/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fhelix_demo/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants