Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prettyplease to improve formatting of generated Rust code #2949

Merged
merged 3 commits into from Aug 9, 2023
Merged

Use prettyplease to improve formatting of generated Rust code #2949

merged 3 commits into from Aug 9, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 9, 2023 •
edited by github-actions bot

What

Use prettyplease to format our generated Rust code, before also running cargo fmt on it. Yes, we need both.

Example of the resulting improvement:

image

Checklist

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) codegen/idl labels Aug 9, 2023
jleibs
jleibs approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@emilk emilk merged commit 481e852 into main Aug 9, 2023
23 checks passed
@emilk emilk deleted the emilk/prettyplease branch August 9, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
codegen/idl 🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use prettyplease instead of rustfmt for generated code
2 participants
@emilk @jleibs