Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Welcome Screen after closing recording even with --skip-welcome-screen #3035

Merged
merged 4 commits into from Aug 22, 2023
Merged

Show Welcome Screen after closing recording even with --skip-welcome-screen #3035

merged 4 commits into from Aug 22, 2023

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Aug 18, 2023 •
edited

What

Fixes #3018

Export-1692347071463.mp4

Checklist

@abey79 abey79 added the ui concerns graphical user interface label Aug 18, 2023
@abey79 abey79 requested a review from emilk August 18, 2023 15:14
emilk
emilk reviewed Aug 21, 2023
View reviewed changes
crates/re_viewer/src/app.rs Outdated Show resolved Hide resolved
@rerun-io rerun-io deleted a comment from github-actions bot Aug 22, 2023
@abey79 abey79 merged commit e210793 into main Aug 22, 2023
26 checks passed
@abey79 abey79 deleted the antoine/override-skip-welcome-screen branch August 22, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the welcome screen when closing recordings even with --skip-welcome-screen
2 participants
@abey79 @emilk