Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name the rayon threads #3060

Merged
merged 1 commit into from Aug 22, 2023
Merged

Name the rayon threads #3060

merged 1 commit into from Aug 22, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 22, 2023 •
edited by github-actions bot

The names show up in crash logs, debuggers, the puffin profiler, etc

Checklist

@emilk
Name the rayon threads
3e05dd1 
The names show up in the puffin profiler and in debuggers
@emilk emilk added the 🧑‍💻 dev experience developer experience (excluding CI) label Aug 22, 2023
@github-actions
Copy link

Size changes

Name Previous Current Change
Wasm (none) 13.499 MB +100%
JS (none) 107.698 KB +100%
arkit_scenes.rrd (none) 41646.607 KB +100%
detect_and_track_objects.rrd (none) 59522.062 KB +100%
dicom_mri.rrd (none) 64877.031 KB +100%
dna.rrd (none) 781.389 KB +100%
human_pose_tracking.rrd (none) 56974.646 KB +100%
plots.rrd (none) 257.779 KB +100%
structure_from_motion.rrd (none) 7078.588 KB +100%

Wumpf
Wumpf approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very likeable. Also a bit sad that rayon doesn't name its threads.

@Wumpf Wumpf merged commit 0a9e60c into main Aug 22, 2023
27 checks passed
@Wumpf Wumpf deleted the emilk/name-rayon-threads branch August 22, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf