Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.72 + format let-else (!) #3102

Merged
merged 14 commits into from Aug 25, 2023
Merged

Rust 1.72 + format let-else (!) #3102

merged 14 commits into from Aug 25, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 25, 2023 •
edited by emilk

Woohoo

What

Checklist

@teh-cmc teh-cmc added the dependencies concerning crates, pip packages etc label Aug 25, 2023
emilk
emilk requested changes Aug 25, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs:

  • Search for 1.69 and update where it needs updating.
  • New docker_ci
  • Fix cc crashing on Mac with pointer not aligned at address

@emilk emilk added the do-not-merge Do not merge this PR label Aug 25, 2023
@emilk emilk removed the do-not-merge Do not merge this PR label Aug 25, 2023
emilk
emilk approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@emilk emilk merged commit 4c33262 into main Aug 25, 2023
27 of 28 checks passed
@emilk emilk deleted the cmc/rust172 branch August 25, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teh-cmc @emilk @abey79 @jleibs