Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if using software rasterizer (lavapipe or llvmpipe) #3134

Merged
merged 4 commits into from Aug 30, 2023
Merged

Warn if using software rasterizer (lavapipe or llvmpipe) #3134

merged 4 commits into from Aug 30, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 29, 2023 •
edited by github-actions bot

@emilk emilk added this to the 0.8.2 milestone Aug 29, 2023
@emilk emilk added 🔺 re_renderer affects re_renderer itself 🐧 linux Linux-specific problems labels Aug 29, 2023
@teh-cmc teh-cmc self-requested a review August 30, 2023 07:30
teh-cmc
teh-cmc approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to deal with a gazillon LLVM issues to get lavapipe working in the first place; but then rerun just works:
image

@emilk
Copy link
Member Author

emilk commented Aug 30, 2023 •
edited

Thanks for testing, Clement ❤️

I wonder if we should warn for all device_type: Cpu

@emilk
Copy link
Member Author

emilk commented Aug 30, 2023

Can you please copy-paste that wgpu adapter name log row? 🙏

@teh-cmc
Copy link
Member

teh-cmc commented Aug 30, 2023

Can you please copy-paste that wgpu adapter name log row? 🙏

[2023-08-30T07:45:19Z WARN  re_viewer::native] Software rasterizer detected - expect poor performance and crashes. See: https://www.rerun.io/docs/getting-started/troubleshooting#graphics-issues
[2023-08-30T07:45:19Z INFO  re_viewer::native] wgpu adapter name: "llvmpipe (LLVM 16.0.6, 256 bits)", device_type: Cpu, backend: Vulkan, driver: "llvmpipe", driver_info: "Mesa 23.1.6-arch1.4 (LLVM 16.0.6)"

@emilk emilk merged commit d9207a2 into main Aug 30, 2023
26 checks passed
@emilk emilk deleted the emilk/warn-about-software-rasterizers branch August 30, 2023 09:31
jleibs pushed a commit that referenced this pull request Aug 31, 2023
@emilk @jleibs
Warn if using software rasterizer (lavapipe or llvmpipe) (#3134)
d35c50c 
* Closes #3089

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3134) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3134)
- [Docs
preview](https://rerun.io/preview/7fe03de920836b35fab0903613a762a12e0ed4e2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7fe03de920836b35fab0903613a762a12e0ed4e2/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs pushed a commit that referenced this pull request Aug 31, 2023
@emilk @jleibs
Warn if using software rasterizer (lavapipe or llvmpipe) (#3134)
3ba5940 
* Closes #3089

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3134) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3134)
- [Docs
preview](https://rerun.io/preview/7fe03de920836b35fab0903613a762a12e0ed4e2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7fe03de920836b35fab0903613a762a12e0ed4e2/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
jleibs pushed a commit that referenced this pull request Aug 31, 2023
@emilk @jleibs
Warn if using software rasterizer (lavapipe or llvmpipe) (#3134)
e205452 
* Closes #3089

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3134) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3134)
- [Docs
preview](https://rerun.io/preview/7fe03de920836b35fab0903613a762a12e0ed4e2/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7fe03de920836b35fab0903613a762a12e0ed4e2/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@jleibs jleibs mentioned this pull request Aug 31, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
🐧 linux Linux-specific problems 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
0.8.2
Development

Successfully merging this pull request may close these issues.

Print clearly visible warning if OpenGL/Vulkan runs with llvmpipe/lavapipe driver
2 participants
@emilk @teh-cmc