Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize out unnecessary joins when querying archetypes #3377

Merged
merged 6 commits into from Sep 20, 2023
Merged

Optimize out unnecessary joins when querying archetypes #3377

merged 6 commits into from Sep 20, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Sep 20, 2023 •
edited by github-actions bot

What the title says; see the commits for details, it's pretty trivial.

Going from a ~62ms space view build time to ~40ms in the OPF example, so pretty nice gains overall.

OPF, before:
image (17)

OPF, after:
image

What

Checklist

@teh-cmc teh-cmc added 📺 re_viewer affects re_viewer itself 📉 performance Optimization, memory use, etc labels Sep 20, 2023
@teh-cmc teh-cmc marked this pull request as ready for review September 20, 2023 08:39
emilk
emilk approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was easy 🥳

@teh-cmc
Copy link
Member Author

teh-cmc commented Sep 20, 2023

I'm seeing more low-hanging fruit in that function... gimme a sec... 👀

@teh-cmc
Copy link
Member Author

teh-cmc commented Sep 20, 2023

Alright, grabbed all the milliseconds I could: 62ms -> 40ms to build the point3d view in OPF.

Now let's see how all that behaves with the new mesh archetype.

This was referenced Sep 20, 2023
Merged
Closed
@teh-cmc
Copy link
Member Author

teh-cmc commented Sep 20, 2023

Future work:

@teh-cmc teh-cmc force-pushed the cmc/dont_join_if_you_dont_have_to branch from f40d3a3 to b0410c8 Compare September 20, 2023 11:15
emilk
emilk approved these changes Sep 20, 2023
View reviewed changes
crates/re_query/src/archetype_view.rs Outdated Show resolved Hide resolved
crates/re_query/src/archetype_view.rs Show resolved Hide resolved
@teh-cmc teh-cmc merged commit 84581b7 into main Sep 20, 2023
13 of 19 checks passed
@teh-cmc teh-cmc deleted the cmc/dont_join_if_you_dont_have_to branch September 20, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📉 performance Optimization, memory use, etc 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize out unnecessary joins across autogenerated instance keys
2 participants
@teh-cmc @emilk