Fix transform3d_simple and reenable roundtrip test
#3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🔨 testing
teh-cmc
force-pushed
the
cmc/bring_back_transform3d_simple
branch
from
c0a1fd8
to
ad3c1ce
Compare
They were all logging slightly different data so roundtrip was broken and thus commented out. |
emilk
approved these changes
Sep 22, 2023
emilk
reviewed
Sep 22, 2023
| @@ -31,7 +31,7 @@ class TensorBuffer(TensorBufferExt): | |||
|
|
|||
| # You can define your own __init__ function as a member of TensorBufferExt in tensor_buffer_ext.py | |||
|
|
|||
| inner: npt.NDArray[np.float16] | (npt.NDArray[np.float32] | (npt.NDArray[np.float64] | (npt.NDArray[np.int16] | (npt.NDArray[np.int32] | (npt.NDArray[np.int64] | (npt.NDArray[np.int8] | (npt.NDArray[np.uint16] | (npt.NDArray[np.uint32] | (npt.NDArray[np.uint64] | npt.NDArray[np.uint8]))))))))) = field(converter=TensorBufferExt.inner__field_converter_override) # type: ignore[misc] | |||
teh-cmc
force-pushed
the
cmc/bring_back_transform3d_simple
branch
from
ad3c1ce
to
eddb08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
What
Checklist