Remove legacy re_components
#3440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
commented
Sep 25, 2023
Comment on lines
-216
to
-263
| /// Check that known (`rerun.`) components have the expected schemas. | ||
| #[cfg(debug_assertions)] | ||
| fn check_known_component_schemas(msg: &ArrowMsg) { | ||
| // Check that we have the expected schemas | ||
| let known_fields: ahash::HashMap<&str, &arrow2::datatypes::Field> = | ||
| re_components::iter_registered_field_types() | ||
| .map(|field| (field.name.as_str(), field)) | ||
| .collect(); | ||
|
|
||
| for actual in &msg.schema.fields { | ||
| if let Some(expected) = known_fields.get(actual.name.as_str()) { | ||
| if let arrow2::datatypes::DataType::List(actual_field) = &actual.data_type { | ||
| // NOTE: Don't care about extensions until the migration is over (arrow2-convert | ||
| // issues). | ||
| let actual_datatype = actual_field.data_type.to_logical_type(); | ||
| let expected_datatype = expected.data_type.to_logical_type(); | ||
| if actual_datatype != expected_datatype { | ||
| re_log::warn_once!( | ||
| "The incoming component {:?} had the type:\n{:#?}\nExpected type:\n{:#?}", | ||
| actual.name, | ||
| actual_field.data_type, | ||
| expected.data_type, | ||
| ); | ||
| } | ||
| if actual.is_nullable != expected.is_nullable { | ||
| re_log::warn_once!( | ||
| "The incoming component {:?} has is_nullable={}, expected is_nullable={}", | ||
| actual.name, | ||
| actual.is_nullable, | ||
| expected.is_nullable, | ||
| ); | ||
| } | ||
| } else { | ||
| re_log::warn_once!( | ||
| "The incoming component {:?} was:\n{:#?}\nExpected:\n{:#?}", | ||
| actual.name, | ||
| actual.data_type, | ||
| expected.data_type, | ||
| ); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't have a registry anymore, and this is already covered by roundtrips.
|
Waiting to see how the attempted removal of the legacy python |
teh-cmc
force-pushed
the
cmc/burn_re_components
branch
from
e6e5dad
to
e9596e4
Compare
teh-cmc
force-pushed
the
cmc/burn_re_components
branch
from
640baf0
to
ce1ef1f
Compare
teh-cmc
added
⛴ release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the grunt work necessary to get rid of
re_componentsentirely.Mostly surprise-free.
What
Checklist