Force kw-args on more Python functions #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
emilk/more-kwargs
branch
from
01c2632
to
f6c9382
Compare
emilk
changed the title
log and log_components
emilk
force-pushed
the
emilk/more-kwargs
branch
from
4e6a9b2
to
6ac92c3
Compare
emilk
force-pushed
the
emilk/more-kwargs
branch
from
d49574b
to
5d7d9f6
Compare
Wumpf
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This forces the user to write out the names of arguments for a lot more of our functions. This makes the code easier to read, and more future-proof for when we add or remove arguments.
Checklist