Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn/raise when passing incompatible objects to log #3727

Merged
merged 3 commits into from Oct 7, 2023
Merged

Warn/raise when passing incompatible objects to log #3727

merged 3 commits into from Oct 7, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 6, 2023 •
edited by github-actions bot

What

Before:

transform3d_simple.py:11: RerunWarning: log: TypeError('TranslationAndMat3x3' object is not iterable)
  rr.log("base/translated", rr.TranslationAndMat3x3(translation=[1, 0, 0]))

After:

transform3d_simple.py:11: RerunWarning: log: TypeError(Expected an object implementing rerun.AsComponents or an iterable of rerun.ComponentBatchLike, but got <class 'rerun.datatypes.translation_and_mat3x3.TranslationAndMat3x3'> instead.)
  rr.log("base/translated", rr.TranslationAndMat3x3(translation=[1, 0, 0]))

Checklist

@jleibs jleibs added this to the 0.9.1 milestone Oct 6, 2023
@jleibs jleibs marked this pull request as ready for review October 6, 2023 18:32
emilk
emilk approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good error messages ❤️

@emilk emilk merged commit 25f157f into main Oct 7, 2023
30 checks passed
@emilk emilk deleted the jleibs/improve_log_error branch October 7, 2023 11:38
@emilk emilk changed the title Warn/raise when passing incompatible objects to log Warn/raise when passing incompatible objects to log Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

Logging TranslationAndMat3x3 / TranslationRotationScale3D fails
2 participants
@jleibs @emilk