Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export the RecordingStreamError type from re_sdk and rerun. #3786

Closed
wants to merge 1 commit into from
Closed

Export the RecordingStreamError type from re_sdk and rerun. #3786

wants to merge 1 commit into from

Conversation

kpreid
Copy link
Collaborator

@kpreid kpreid commented Oct 10, 2023 •
edited by github-actions bot
Loading

What

Fixes #3735 by exporting the previously effectively-private type RecordingStreamError from re_sdk.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@kpreid kpreid mentioned this pull request Oct 10, 2023
Closed
@jleibs
Copy link
Member

jleibs commented Oct 10, 2023

Thank you for the contribution, @kpreid ! Unfortunately, I think you and @emilk may have done the same work in parallel -- seems like this is a partial duplicate of #3777 which should hopefully be merged shortly.

@kpreid kpreid closed this Oct 10, 2023
@kpreid kpreid deleted the error branch December 31, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust API: Expose RecordingStreamError
2 participants
@kpreid @jleibs