Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RERUN_STRICT environment variable #3861

Merged
merged 7 commits into from Oct 16, 2023
Merged

Add RERUN_STRICT environment variable #3861

merged 7 commits into from Oct 16, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 16, 2023 •
edited by github-actions bot

What

If RERUN_STRICT is set to a truthy value (1, ON, YES, TRUE), then errors in C++ and Python will be handled by throwing an exception.

We enabled this for our tests.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@emilk emilk added 🐍 Python API Python logging API 🌊 C++ API C or C++ logging API include in changelog labels Oct 16, 2023
@Wumpf Wumpf self-requested a review October 16, 2023 13:04
Wumpf
Wumpf approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@emilk emilk merged commit cca2069 into main Oct 16, 2023
30 checks passed
@emilk emilk deleted the emilk/cpp-strict-mode branch October 16, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C or C++ logging API include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf