Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update egui_commonmark to 0.9 #3882

Merged
merged 1 commit into from Oct 17, 2023
Merged

Update egui_commonmark to 0.9 #3882

merged 1 commit into from Oct 17, 2023

Conversation

abey79
Copy link
Contributor

@abey79 abey79 commented Oct 17, 2023 •
edited

What

Gives us copy button in code blocks:

image

Note: copy/paste seems to not work from web/Safari emilk/egui#3480.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@abey79
Bump egui_commonmark to 0.9
79bc94f 
This gives use a copy button in code blocks.
@abey79 abey79 added include in changelog ui concerns graphical user interface labels Oct 17, 2023
@Wumpf Wumpf self-requested a review October 17, 2023 08:19
Wumpf
Wumpf approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! Confirmed working with Firefox on Mac via https://demo.rerun.io/pr/3882/examples/arkit_scenes/

@Wumpf Wumpf added the dependencies concerning crates, pip packages etc label Oct 17, 2023
@Wumpf Wumpf changed the title Bump egui_commonmark to 0.9 Update egui_commonmark to 0.9 Oct 17, 2023
@Wumpf Wumpf merged commit 59f4f6e into main Oct 17, 2023
35 of 40 checks passed
@Wumpf Wumpf deleted the antoine/egui-commonmark-0.9 branch October 17, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abey79 @Wumpf