Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: remove legacy APIs #4037

Merged
merged 8 commits into from Nov 7, 2023
Merged

Python: remove legacy APIs #4037

merged 8 commits into from Nov 7, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 27, 2023 •
edited

I've also added AnnotationInfo & ClassDescription at the root-level init.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🐍 Python API Python logging API include in changelog do-not-merge Do not merge this PR labels Oct 27, 2023
@teh-cmc teh-cmc marked this pull request as draft October 27, 2023 08:56
@teh-cmc
Copy link
Member Author

teh-cmc commented Nov 6, 2023

I'll get back to this once I'm done with the StoreViewsStoreDb/EntityDb/EntityTree story arc, unless someone beats me to it.

@teh-cmc teh-cmc marked this pull request as ready for review November 7, 2023 15:52
@Wumpf Wumpf self-requested a review November 7, 2023 16:22
Wumpf
Wumpf approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Nov 7, 2023
@teh-cmc teh-cmc merged commit 01bbdbc into main Nov 7, 2023
37 of 40 checks passed
@teh-cmc teh-cmc deleted the cmc/total_annihilation branch November 7, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated Python APIs
2 participants
@teh-cmc @Wumpf