Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust SDK: expose clap in externals #4040

Merged
merged 1 commit into from Oct 27, 2023
Merged

Rust SDK: expose clap in externals #4040

merged 1 commit into from Oct 27, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 27, 2023 •
edited by github-actions bot

Very annoying to have to manually cargo add clap when using our clap integration 🤦‍♂️

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 🦀 Rust API Rust logging API 🧑‍💻 dev experience developer experience (excluding CI) dependencies concerning crates, pip packages etc include in changelog labels Oct 27, 2023
@teh-cmc teh-cmc changed the title expose clap in externals Rust SDK: expose clap in externals Oct 27, 2023
Wumpf
Wumpf approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. good qol fix

@teh-cmc teh-cmc merged commit a5f514c into main Oct 27, 2023
38 of 40 checks passed
@teh-cmc teh-cmc deleted the cmc/expose_clap branch October 27, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
dependencies concerning crates, pip packages etc 🧑‍💻 dev experience developer experience (excluding CI) include in changelog 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh-cmc @Wumpf