Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Doxygen documentation & many doc improvements #4191

Merged
merged 37 commits into from Nov 10, 2023
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 9, 2023

What

Try it yourself:
https://wumpf.github.io/rerun-cpp-doc-test/
(yes I sacrificed a repo for this ;))
Or to get a perfect up to date version now and in the future just run pixi run cpp-docs, the docs appear then in rerun_cpp/docs/html/index.html

  • fixes almost C++ API Docs webpage #3974
  • Missing are:
    • process to upload it to landing and link it up in our docs
    • more thorough pass to improve docs overall
      • lots of stuff is undocumented. We should consider making this an error in doxygen (I disabled it for the time being!)

After some back and forth I landed with a pure doxygen documentation using the impressively good https://jothepro.github.io/doxygen-awesome-css/ css.
To avoid submoduling and make customization easy, the theme is embedded in our repo.

Otherwise tons of improvements on our doc strings. Started a guide on how to write docs similar to what we have for python.

Quite happy with it as-is already. Some of the doc improvements to be done are also related to smaller code refactors I want to do :)

Review tip: The first commit contains the default doxygen file, if you want to know what I changed about it just exclude it.

Bunch of screenshots for the lazy:
image
image
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

…ort members, warn as error, skip cpp & h files
@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation 🌊 C++ API C or C++ logging API include in changelog labels Nov 9, 2023
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward and works great.

Problem for later: namespaces section looks empty:
image

@Wumpf
Copy link
Member Author

Wumpf commented Nov 10, 2023

Problem for later: namespaces section looks empty

Hmm good catch. I'll look into this after landing!
Somehow that's not the case on https://docs.opencv.org/5.x/namespaces.html (which uses the same theme)

@Wumpf Wumpf mentioned this pull request Nov 10, 2023
@Wumpf Wumpf merged commit 8bff997 into main Nov 10, 2023
40 checks passed
@Wumpf Wumpf deleted the andreas/cpp/docs2 branch November 10, 2023 11:09
@Wumpf Wumpf mentioned this pull request Nov 13, 2023
4 tasks
Wumpf added a commit that referenced this pull request Nov 13, 2023
### What

* Almost fixe_s #3974
* Follow-up of #4191

A few remaining items & polish for the C++ docs. Now uploaded to
gh-pages as well on push to main (🤞 it works.......)

Commit by commit!

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4212) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4212)
- [Docs
preview](https://rerun.io/preview/4d098307e728ccea06f408df01f700dda18739c1/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4d098307e728ccea06f408df01f700dda18739c1/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C or C++ logging API 📖 documentation Improvements or additions to documentation include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants