Formalize behaviour of our many time histograms in a test suite #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
force-pushed
the
cmc/time_counts_test
branch
from
7113e35
to
331fcac
Compare
teh-cmc
force-pushed
the
cmc/time_counts_test
branch
from
331fcac
to
45685e5
Compare
4 tasks
teh-cmc
added
🔨 testing
teh-cmc
added a commit
that referenced
this pull request
Nov 15, 2023
…4202) The upcoming `StoreView` works in global scope: by registering a view you subscribe to changes to _all_ `DataStore`s, including those that are yet to be created. This is very powerful as it allows views & triggers implementers to build cross-recording indices as well as be notified as soon as new recordings come in and go out. But it means that `StoreEvent`s must indicate which `DataStore` they originate from, which isn't possible today since the stores themselves don't know who they are to begin with. This trivial PR plumbs the `StoreId` all the way through so `DataStore`s know about their own ID. Also made `StoreGeneration` account for the GC counter while I was at it. --- Requires: - #4215 `DataStore` changelog PR series: - #4202 - #4203 - #4205 - #4206 - #4208 - #4209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We maintain three different kinds of time histograms as part of our
EntityDb:times_per_timeline: instantiated once perEntityDb, this keeps track of the number of distinct times per timeline that have been logged to, across all entities and components.prefix_times: instantiated once perEntityTree(and thus once per entity path), this keeps track of the number of raw components that have been logged per timestamp, across this entity and its recursive children.components: instantiated once perEntityTreeperComponentName, this keeps track of the number of raw components that have been logged per timestamp per component, just for this entity.For each of those we have to ask ourselves:
Clearevents?Answers to these questions are now formalized in a test suite, A) allowing us to easily iterate on them in the future and B) allowing me to match the current behavior in new event-driven
EntityTreethat's about to ship.This also highlighted a bug in the current implementation, which is fixed in the upcoming one.
Checklist