Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StoreView -> StoreSubscriber #4234

Merged
merged 3 commits into from Nov 15, 2023
Merged

StoreView -> StoreSubscriber #4234

merged 3 commits into from Nov 15, 2023

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Nov 15, 2023 •
edited by github-actions bot

Better done sooner than later 😬

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🚜 refactor Change the code, not the functionality include in changelog labels Nov 15, 2023
emilk
emilk approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@teh-cmc teh-cmc merged commit c640da8 into main Nov 15, 2023
37 checks passed
@teh-cmc teh-cmc deleted the cmc/store_subscriber branch November 15, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
include in changelog ⛃ re_datastore affects the datastore itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teh-cmc @emilk